Allow style sheets to be used #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
reviewed
Jun 20, 2023
|
Just for my sanity: #160 which is passing here is sufficient. |
Co-authored-by: Sam Cunliffe <[email protected]>
samcunliffe
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimum viable implementation for using Matplotlb style sheets. Currently light and dark style sheets are hardcoded (taken from #157), instead of being generated from the napari theme. I think this is a better approach, as even though it's less general, I doubt the napari folks will be changing their theme very often so manually updating our theme when they do is a reasonable ask.
This doesn't deal with whether we should look for user style sheets, but does let the users set the style sheet property with a path to their own style sheet. We can follow this PR up with a PR to add a location where users can put a custom style sheet.
This still needs: